mozilla / source-map / 554

89%

master: 89%

Pull #392

travis-ci

binary-search fixes:
- always use the NEEDLE as the first argument for the comparison function. Otherwise you get very nasty comparisons (which don't hurt, but are utterly useless) like these in *indexed maps* at least:
  watch for the compareValue/compareValue2 = **NaN** log lines below: this is due to a useless (due to way it was invoked!) call to `aCompare` at the end of binary-search.
  The log below is a heavily instrumented `originalPositionFor()` API test run which was failing for indexed maps.
  ```
originalPositionFor: { generatedLine: 2, generatedColumn: 3 }

# search round 1
binarySearch SECTIONS: { needle: { generatedLine: 2, generatedColumn: 3 },
  'section.generatedOffset': { generatedLine: 1, generatedColumn: 1 },
  compareCheck: 1,
  compareValue2: 3 }

# search round 2
binarySearch SECTIONS: { needle: { generatedLine: 2, generatedColumn: 3 },
  'section.generatedOffset': { generatedLine: 1, generatedColumn: 3 },
  compareCheck: 1,
  compareValue2: 1 }

# while loop round 1; always fails thanks to NaNs.
# That ain't no needle being fed to it!
binarySearch SECTIONS: { needle:
   { generatedOffset: { generatedLine: 1, generatedColumn: 3 },
     consumer:
      BasicSourceMapConsumer {
        _sourceLookupCache: Map {},
        _names: [Object],
        _sources: [Object],
        _absoluteSources: [Object],
        sourceRoot: null,
        sourcesContent: null,
        _mappings: 'AAAAA,CCCCC',
        _sourceMapURL: undefined,
        file: null,
        _computedColumnSpans: false,
        _mappingsPtr: 1114216,
        _wasm: [Object] } },
  'section.generatedOffset': { generatedLine: 1, generatedColumn: 1 },
  compareCheck: NaN,
  compareValue2: NaN }
binarySearch SECTIONS --> found @ index: { sectionIndex: 1,
  section:
   { generatedOffset: { generatedLine: 1, generatedColumn: 3 },
     consumer:
      BasicSourceMapConsumer {
        _sourceLookupCache: Map {},
        _names: [Object],
        _sources: [Object],
        _absol... (continued)

462 of 544 branches covered (84.93%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

824 of 911 relevant lines covered (90.45%)

654.47 hits per line