nokia / danm / 488

25%

master: 44%

Pull #97

travis-ci

Multiple problems occured during testing.

1: Looks like we are patching VLAN and VxLAN IDs as string for TenantNetworks.
This resulted in netwatcher not being able to handle host interfaces, as decoding failed.
We have defined "value" in the Patch struct as RawMessage, which implicitly resulted in always creating "string" patches.
Changed the type to "interface{}" to mimic the official, upstream type, and let json.Marshal take care of creating the appropriate byte[] representation.
2: For some reason ClusterNetworks and TenantNetworks Informers complain during DELETE... but not DanmNet Informer.
Trying to use separate clients and factories per API, maybe it is a multi-treading issue?
Update: turned out these items are tombstone items! We need to handle them gracefully, they might hold our objects.
3: We also unfortunetaly can't avoid separate handlers for each API due to static type correctness.
4: We need to make sure that we only try to create and start an Informer, if its respective API is present in the cluster.
We solve this by doing a "List" first, and only create the Informer if listing was successful.
5: During initial sycnhing TN and CN endpoints received DN objects for some reason
Turns out Informers List during synching. Changing CN and TN List struct to contain the right type solved the issue.

185 of 185 new or added lines in 3 files covered. (100.0%)

541 of 2177 relevant lines covered (24.85%)

6.32 hits per line