preactjs / preact / 4557

100%

push

travis-ci

Bubble up Component dom changes up the virtual tree (+51 B) (#1700)

If a component changed it's DOM node and was wrapped in other Components, the parent Components _dom and .base pointer could become out of date. Since this.base is a public API feature on Components, I figured this need to be fixed.

This might slightly decrease our memory footprint as we won't have pointers to useless DOM nodes anymore. Also fixes some cases where we would needlessly append DOM nodes to parents that are no longer mounted (see comment in fragments.test.js)

Total change: +36 B 😐
Total change: +48 B 😕
Total change: +51 B 😕

802 of 860 branches covered (93.26%)

23 of 23 new or added lines in 5 files covered. (100.0%)

906 of 916 relevant lines covered (98.91%)

735.39 hits per line