1174
64%

Ran 14 Jun 2019 10:03AM UTC

Jobs 1

Files 23

Run time 2s

Badge

Embed ▾

pending completion

Build # 1174

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Support per-experiment ReverseProxyProbability  (#199)

* Change get_reverse_proxy to accept an experiment name.

* Make pylint happy.

* Make pyflakes happy.

* Add log message.

* Change reverse_proxy.py to not use class methods.

Apparently memcache (and the underlying cPickle) doesn't like when the
class it's trying to serialize has been patched. The former code used the
get_by_key_name class method and was then patching it with MagicMock in
the test, and this made memcache.set() fail.

I reverted the code back to the previous behavior of reading and caching
*all* the entities in Datastore whenever the probability for any experiment
is requested, which makes sense to me since:

1. they all have the same expiration and
2. they are both requested very often when mlab-ns is running in production

So, the total number of calls to Datastore will be (slightly) smaller this way.

* Change tests to use the emulated Datastore/memcache instead of mocking.

* Make get_reverse_proxy return probability if memcache.set fails.

* Add whitespace between test setup and execution.

* Fix logic to avoid the extra call to memcache.get().

* Change get_reverse_proxy to return a default entity with the requested name.

Also, set probability for this default entity to 0.0.

* Update comments.

* s/records/record/

Run Details

1076 of 1618 relevant lines covered (66.5%)

0.67 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1174.1 (PYTHONPATH=$PYTHONPATH:$HOME/google-cloud-sdk/platform/google_appengine)	14 Jun 2019 10:03AM UTC	0	66.5	Travis Job 1174.1

Source Files on build 1174

Detailed source file information is not available for this build.

m-lab / mlab-ns / 1174
64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1174

m-lab / mlab-ns / 1174 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1174

m-lab / mlab-ns / 1174
64%

README BADGES
x