firebase / firebase-tools / 4239

66%

push

travis-ci

Adds check for cloud resource location for features that require it (#1383)

* convert firebaseApi and init/features/project to typescript

* change to use async/await

* add jsdoc on the interfaces

* fix default export

* format

* remove default function, ts-ify storage

* add cast to Question to keep validate function

* delete project.d.ts and move interfaces in with source code

* fix interfaces, remote lint disables, refactor

* Error => FirebaseError

* add tests to project init and storage init

* add firestore tests - refactor and ts-ifying proved necessary to do this

* use index.ts to remove extra /firestore in imports

* add check for cloud resource location

* format

* review comment fixes, remove validate function

* small format and type fixes

* sinon-chai changes

* fix bug in storage initialization

* remove only

* fix storage unit test

* format changes

* adding tests to check for location

* remove only. We should really come up with a better way to run single tests

* move location check to where we call scheduler

* review suggestions and fixes

* add changelog

* add test for scheduled function without location

812 of 1690 branches covered (48.05%)

14 of 14 new or added lines in 5 files covered. (100.0%)

2542 of 4110 relevant lines covered (61.85%)

170.88 hits per line