firebase / firebase-tools / 4111

65%

master: 66%

push

travis-ci

[Breaking Change] Enforce engines field present in package.json for functions deploys (#1220)

* Refactor functions prepare step to allow for engines check

* Split out validation logic for functions prepare step

* Minor fix in wording in the test for consistency

* Removing strict from ts files, fixing imports, adding jsdocs

* adding sandboxing to sinon tests, adding beforeEach() and afterEach()

* Small fix in jsdoc

* Add a comment about legacy behavior when package.json not found

* split out main field check and engines field check from package.json validation logic

* ran formatter on new tests

* switch to non-deprecated sinon sandbox, fix throw() in tests, add some comments about buggy behavior

* split out main field check and engines field check from package.json validation logic

* ran formatter on new tests

* add engines field check with tests

* fix srcmain.js => src/main.js in a test

* fix regex for validating function names to allow capital letters, and update jsdoc to match

* fix wording in error message and jsdoc on what valid function name should look like

* small change in error message to sound better

* add jsdoc on resolveProjectPath() function

* rename functions that throw errors and add jsdocs to them

* updating changelog with changd behavior

* removing legacy behavior, Firebase Functions => Cloud Functions in error message

* changed => important in changelog

786 of 1635 branches covered (48.07%)

9 of 9 new or added lines in 1 file covered. (100.0%)

2400 of 3894 relevant lines covered (61.63%)

119.85 hits per line