Roblox / roact / 519

95%

push

travis-ci

Remove children when updating a host node to an element with nil children (#210)

* Revert performance improvement

This caused an issue when updating an element that had children - when
an element went from having children to having nil children, the
rendered objects would not be removed.

* add test to verify that #209 is fixed

* update changelog

* Dial back bugfix. Reintroduce performance consideration, add additional check to resolve the bug.

* Preempt review comments

* Update src/RobloxRenderer.lua

Co-Authored-By: Lucien Greathouse <me@lpghatguy.com>

1 of 1 new or added line in 1 file covered. (100.0%)

1126 of 1210 relevant lines covered (93.06%)

39.4 hits per line