OGGM / oggm / 1894

84%

push

travis-ci

Volume Area Scaling (VAS) model from Marzeion et.al., 2012 (#662)

* Adding the first version of the original mass balance model used by Marzeion et.al., 2012, including an altered calibration method. The `test_ben.py` file contains the corresponding unit tests.

*  - Correcting PEP8 issues, mainly too long lines.
 - Deleting the OGGM tests from the `test_ben.py` file

* Tests for the mass balance methods & minor improvements:
- Test for the routine computing the minimal and maximal glacier surface elevation
- Tests for the routines computing the mass balance relevant climate information
- Added `ben_params` as basename in the config file
- Minor changes such as typos and similar

* Test for specific mass balance

* Finalising the mass balance tests
- Test the monthly specific mass balance against the corresponding annual mb
- Test the annual mass balance against the 'manually' computed mass balance
- Add a comparison with the reference mass balance measurements to the spec mb test

* Started to work on the dynamic part (end of day commit):
- Added area-volume and area-lenght scaling parameters to `params.cfg`
- First steps on what will become the `BenModel` class

* Continued to work on the dynamic model (end of day commit):
- Corrected typo in the `cfg.py`
- `step()` function of dynamic model
- `run_until()` function of dynamic model
Note: I'm well aware that the model does not work properly yet. Qualitative tests on Hintereisferner show not observed area/volume/length changes...

* Finalizing the volume/area scaling model.
- Changed the name to VAScaling
- Solved problems with scaling constants
- Solved problem with time scales

* Test for the VAS model
- Testing the length, area and volume output against the OGGM

* VAS model test fine tuning

* Adding routine which calculates the RMSD between the anomalies to the mean of the repective time series.

* Coding sprint leading up to the AGM.

* Adding pytest t... (continued)

561 of 561 new or added lines in 6 files covered. (100.0%)

7780 of 8925 relevant lines covered (87.17%)

3.82 hits per line