micropython / micropython / 10722

98%

push

travis-ci

<a href="https://github.com/micropython/micropython/commit/<a class=hub.com/micropython/micropython/commit/019dd84af1e8e9bbdbbb6377c28950d31f05a77c">019dd84af<a href="https://github.com/micropython/micropython/commit/019dd84af1e8e9bbdbbb6377c28950d31f05a77c">&quot;&gt;extmod/modlwip: Register TCP close-timeout callback before closing PCB.

In </a><a class="double-link" href="https://github.com/micropython/micropython/commit/<a class="double-link" href="https://github.com/micropython/micropython/commit/d5f0c87bb985ae344014dc2041fbaad5c522f638">d5f0c87bb</a>">d5f0c87bb</a><a href="https://github.com/micropython/micropython/commit/019dd84af1e8e9bbdbbb6377c28950d31f05a77c"> this call to tcp_poll() was
added to put a timeout on closing TCP sockets.  But after calling
tcp_close() the PCB may be freed and therefore invalid, so tcp_poll() can
not be used at that point.  As a fix this commit calls tcp_poll() before
closing the TCP PCB.  If the PCB is subsequently closed and freed by
tcp_close() or tcp_abort() then the PCB will not be on any active list and
the callback will not be executed, which is the desired behaviour (the
_lwip_tcp_close_poll() callback only needs to be called if the PCB remains
active for longer than the timeout).

18447 of 18824 relevant lines covered (98.0%)

364596.03 hits per line