tarantool / tarantool / 17148

83%

master: 88%

push

travis-ci

<a href="https://github.com/tarantool/tarantool/commit/<a class=hub.com/tarantool/tarantool/commit/aa4b102121fb46bd463c20f51c213fd0df126f92">aa4b10212<a href="https://github.com/tarantool/tarantool/commit/aa4b102121fb46bd463c20f51c213fd0df126f92">&quot;&gt;vinyl: fix deferred DELETE statement lost on commit

Even if a statement isn&amp;#39;t marked as VY_STMT_DEFERRED_DELETE, e.g. it&amp;#39;s
a REPLACE produced by an UPDATE request, it may overwrite a statement in
the transaction write set that is marked so, for instance:

  s = box.schema.space.create(&amp;#39;test&amp;#39;, {engine = &amp;#39;vinyl&amp;#39;})
  pk = s:create_index(&amp;#39;pk&amp;#39;)
  sk = s:create_index(&amp;#39;sk&amp;#39;, {parts = {2, &amp;#39;unsigned&amp;#39;}})

  s:insert{1, 1}

  box.begin()
  s:replace{1, 2}
  s:update(1, {{&amp;#39;=&amp;#39;, 2, 3}})
  box.commit()

If we don&amp;#39;t mark REPLACE{3,1} produced by the update operatoin with
VY_STMT_DEFERRED_DELETE flag, we will never generate a DELETE statement
for INSERT{1,1}. That is, we must inherit the flag from the overwritten
statement when we insert a new one into a write set.

Closes #4248

(cherry picked from commit </a><a class="double-link" href="https://github.com/tarantool/tarantool/commit/<a class="double-link" href="https://github.com/tarantool/tarantool/commit/b54433d92586863a767791b7f95c7bdb20a648c9">b54433d92</a>">b54433d92</a><a href="https://github.com/tarantool/tarantool/commit/aa4b102121fb46bd463c20f51c213fd0df126f92">)

3 of 3 new or added lines in 1 file covered. (100.0%)

41560 of 50410 relevant lines covered (82.44%)

843170.9 hits per line