xerions / mariaex / 589

86%

master: 78%

Pull #253

travis-ci

Fix for OTP 21.3+.

As of `[6168cf2]` in OTP 21.3, TLS/SSL sockets are active over top of
the TCP sockets. For example, when a SSL socket is in passive mode,
running an `:inet.getopts(tls_socket, [:active])` will show something
like `[active,96]`, where-in `96` refers to the fourth packet received,
starting at `100` (the default).

However, Mariaex was originally written before this `active,N`
implementation.  As such, changing the TCP socket into `active,once`
mode behaved "as expected". To my best understanding, Mariaex does this
in order to "flush" the state buffers. Of course, with the `active,N`
behaviour of SSL, once Mariaex puts the TCP socket into `active,once`,
after the next message delivery, the SSL socket becomes passive. This
seemed to create a situation where no further SSL data was made
available.

This change attempts to remove the transition into `active,once` and,
instead, tries to keep the socket passive at all times.

[6168cf2]: https://github.com/erlang/otp/commit/6168cf2f5

4 of 4 new or added lines in 1 file covered. (100.0%)

240 of 280 relevant lines covered (85.71%)

4033.95 hits per line