jstasiak / python-zeroconf / 401

94%

push

travis-ci

Add support for multiple addresses when publishing a service (#170)

This is a rebased and fixed version of PR #27, which also adds compatibility shim for ServiceInfo.address and does a proper deprecation for it.

* Present all addresses that are available.

* Add support for publishing multiple addresses.

* Add test for backwards compatibility.

* Provide proper deprecation of the "address" argument and field

* Raise deprecation warnings when address is used
* Add a compatibility property to avoid breaking existing code
  (based on suggestion by Bas Stottelaar in PR #27)
* Make addresses keyword-only, so that address can be eventually
  removed and replaced with it without breaking consumers
* Raise TypeError instead of an assertion on conflicting address
  and addresses

* Disable black on ServiceInfo.__init__ until black is fixed

Due to https://github.com/python/black/issues/759 black produces
code that is invalid Python 3.5 syntax even with --target-version py35.
This patch disables reformatting for this call (it doesn't seem to be
possible per line) until it's fixed.

36 of 36 new or added lines in 1 file covered. (100.0%)

1164 of 1243 relevant lines covered (93.64%)

3.75 hits per line