zooniverse / Panoptes-Front-End / 9634

56%

push

travis-ci

Only show intervention messages if workflow matches payload (#5346)

* add workflow check to incoming interventions

ensure we only add interventions messages the workflow_id is supplied on incoming messages

* check intervention workflows matches known state

if the intervention messages includes a workflow_id, ensure this id matches the known workflow store state.

If intervention workflow_id property is missing then default back to project state comparison only, i.e. allow project messages for all workflows.

* reuse the matchesWorkflow variable

* extract out common test setup

* compare link IDs as string values

messages from sugar could have ints for the link ids, ensure we compare them as strings.

Ideally the message originator deals with this type cast but anyone with access to sugar can post messages down the channel

* use .toString() instead of String()

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

* another use of toString()

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

* ensure we have a classification from state

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

* return the existing state if no classification

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

* avoid `hasOwnProperty` directly access the attribute

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

* avoid double testing classification exists

Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>

1916 of 5418 branches covered (35.36%)

Branch coverage included in aggregate %.

6613 of 12013 relevant lines covered (55.05%)

6.27 hits per line