helpscout / hsds-react / 2177

94%

push

travis-ci

Pop (Tooltip/Popover): Fix closeOnBodyClick (#624)

This update fixes the closeOnBodyClick mechanic of `Pop`, which powers
`Tooltip` and `Popover`.

The issue was the click handler was never actually called. The solution
was to add `EventListener` to scope on `document.body` to handle the
interaction.

A nice enhancment was added to `Pop` to allow for the user to determine
if the `Pop` component should open/close before it happens with a
`Function` that returns a `boolean`. This enables finer grain control
for situations.

Cyan tests have been added to `Popover` to test these interactions and
integrations.

3445 of 3445 branches covered (100.0%)

Branch coverage included in aggregate %.

10782 of 10782 relevant lines covered (100.0%)

243.4 hits per line