wsmd / react-use-form-state / 322

100%

push

travis-ci

Fix stale closures of event handlers (#76)

* Fix stale closures of callback options in inputs.text et. al.

The implementation of useFormState is problematic because it
caches callback functions passed to inputs.text et. al. This
causes functions like onChange, validate, and onBlur to run with
stale closures, namely, the closure with which they are
initialised.

This commit fixes the issue by removing the `callback` cache from
the implementation. Tests that depended on this buggy behavior
were removed as they are unsupportable features given the current
implementation.

* Re-add getOrSet to useCache

111 of 115 branches covered (96.52%)

Branch coverage included in aggregate %.

182 of 183 relevant lines covered (99.45%)

252.52 hits per line