curl / curl / 10555
77%
master: 37%

LAST BUILD BRANCH: patch-1
DEFAULT BRANCH: master
Ran
Jobs 1
Files 275
Run time 31s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
10555

Pull #3856

travis-ci

web-flow 
Revert "multi: support verbose conncache closure handle"

This reverts commit b0972bc.

- No longer show verbose output for the conncache closure handle.

The offending commit was added so that the conncache closure handle
would inherit verbose mode from the user's easy handle. (Note there is
no way for the user to set options for the closure handle which is why
that was necessary.) Other debug settings such as the debug function
were not also inherited since we determined that could lead to crashes
if the user's per-handle private data was used on an unexpected handle.

The reporter here says he has a debug function to capture the verbose
output, and does not expect or want any output to stderr; however
because the conncache closure handle does not inherit the debug function
the verbose output for that handle does go to stderr.

There are other plausible scenarios as well such as the user redirects
stderr on their handle, which is also not inherited since it could lead
to crashes when used on an unexpected handle.

Short of allowing the user to set options for the conncache closure
handle I don't think there's much we can safely do except no longer
inherit the verbose setting.

Bug: https://curl.haxx.se/mail/lib-2019-05/0021.html
Reported-by: Kristoffer Gleditsch

Ref: https://github.com/curl/curl/pull/3598
Ref: https://github.com/curl/curl/pull/3618

Closes #xxxx
Pull Request #3856: Revert "multi: support verbose conncache closure handle"

22041 of 28810 relevant lines covered (76.5%)

708800.86 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
84.63
 -0.25% lib/easy.c
1
82.06
 0.16% lib/ftp.c
2
83.17
 -0.39% lib/doh.c
Jobs
ID Job ID Ran Files Coverage
26 10555.26 (T=coverage OVERRIDE_CC="CC=gcc-8" OVERRIDE_CXX="CXX=g++-8") 275
76.5
 Travis Job 10555.26
Source Files on build 10555