1664
83%

Ran 07 May 2019 09:02AM UTC

Jobs 10

Files 17

Run time 6min

Badge

Embed ▾

Committed 07 May 2019 09:00AM UTC coverage: 80.671% (-0.002%) from 80.673%

Build # 1664

Build Type

push

travis-ci

Committed by

julienschmidt

Commit Message

packets: reset read deadline before conn check (#964)

* packets: reset read deadline before conn check

If a MySQL connection has been configured with a short `ReadTimeout`,
each read from the TCP connection will be preceded by a
`SetReadDeadline` call, which lingers until the next `SetReadDeadline`.

This can be an issue if the connection becomes stale after staying too
long in the connection pool, because when we attempt to perform a stale
connection check, the Go runtime scheduler will return a timedout error
from the scheduler itself, without letting us get to the kernel to
perform the non-blocking read.

To fix this, reset the read deadline before we perform the connection
check.

* packets: set a 0 deadline

Run Details

2788 of 3456 relevant lines covered (80.67%)

568202.77 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1664.1	07 May 2019 09:03AM UTC	78.66	Travis Job 1664.1
2	1664.2	07 May 2019 09:02AM UTC	79.83	Travis Job 1664.2
3	1664.3	07 May 2019 09:02AM UTC	79.83	Travis Job 1664.3
4	1664.4	07 May 2019 09:03AM UTC	79.83	Travis Job 1664.4
5	1664.5	07 May 2019 09:05AM UTC	79.83	Travis Job 1664.5
6	1664.6 (DB=MYSQL8)	07 May 2019 09:05AM UTC	80.21	Travis Job 1664.6
7	1664.7 (DB=MYSQL57)	07 May 2019 09:05AM UTC	80.15	Travis Job 1664.7
8	1664.8 (DB=MARIA55)	07 May 2019 09:05AM UTC	79.51	Travis Job 1664.8
9	1664.9 (DB=MARIA10_1)	07 May 2019 09:05AM UTC	79.98	Travis Job 1664.9
10	1664.10	07 May 2019 09:08AM UTC	80.18	Travis Job 1664.10

Source Files on build 1664

Detailed source file information is not available for this build.

go-sql-driver / mysql / 1664
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1664

go-sql-driver / mysql / 1664 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1664

go-sql-driver / mysql / 1664
83%

README BADGES
x