theskumar / python-dotenv / 463

89%

master: 88%

Pull #177

travis-ci

Fix unicode/str inconsistency in Python 2

This encodes environment keys and values for `os.environ` in Python 2
and fixes the following issues:

* Values loaded from `.env` being `unicode` whereas regular values being
  `str` (i.e. `bytes`) in Python 2.
* Error when loading `.env` with UTF-8 characters in Python 2.
* `# type: ignore` hiding the issue from the type checker.

`sys.getfilesystemencoding()` is used because it seems to match the
encoding used for environment variables with Python 2.  Since it can
apparently return `None`, we fall back to a default encoding (UTF-8
here) if that's the case.

I tested this on Windows where `"mbcs"` is the file system encoding.
Hopefully, this will also work on other systems.

6 of 6 new or added lines in 1 file covered. (100.0%)

260 of 293 relevant lines covered (88.74%)

6.16 hits per line