commonality / archetypes-rules / 41

100%

push

travis-ci-com

refactor(helpers): reduce complexity

### Summary of changes

1.  test(qa): add sonar scanning
    - Add `sonarqube-scanner` for PR and Refactoring templates
    - Add `dotenv-extended` for 12-factor-style config strategy
    - Replace all copy/paste repo refs with this org/repo

1.  test(config): cover env-config

1.  refactor(complexity): remove unused functions
    - Replace all possible "lodash.is*" functions with 
      "@sindresorhus/is.*"
    - Remove unused lodash dependencies
    - Reduce variable-factory's cyclomatic complexity

1.  docs(readme): fix appveyor badge

1.  ci(travis): fix npm-script

1.  ci(windows): modify test config and expectations

    - Appveyor is not configured to load secret environment variables,
      so simply check to ensure the key counts match.

    - Appveyor doesn't have as many ENV VARs, so assert with
      "toBeLessThanOrEqual".

Closes #4 
Closes #6

90 of 90 branches covered (100.0%)

Branch coverage included in aggregate %.

683 of 683 relevant lines covered (100.0%)

252.55 hits per line