firebase / firebase-tools / 3499

66%

push

travis-ci

Add Node 10 runtime, add deprecation warning when deploying with Node 6, keep default to Node 6 but add warnings (#1223)

* add warnings for node 6 deployments and add node 10 as a supported option

* add tests to getRuntimeChoice

* accidentally left .only() in one of the tests - removing

* remove warning on node 10 deploy, add beta tag to node 10, remove unused getDefaultRuntime() method

* change functions SDK check to return boolean, add constants for runtime, add more rigor to the tests with warning checks

* Add back default runtime behavior with huge warning when used, skip tests requiring presence of engines field in package.json, small refactors

* add chai.use(sinon) to bootstrap, remove from test

* Add changelog entry for Node 10 support

* update changelog.txt added => feature

Co-Authored-By: thechenky <31747099+thechenky@users.noreply.github.com>

* added bug number to the TODOs for tracking

* add { [key: string]: string } typings to runtimes object

* remove redundant typedefs, change red node6 warning to yellow and add example of how to fix

* move @types/semver into devDeps, remove copious indentations in warning

188 of 371 branches covered (50.67%)

1326 of 2122 relevant lines covered (62.49%)

194.6 hits per line