isislovecruft / bridgedb / 947
80%
develop: 91%

LAST BUILD BRANCH: bridgedb-0.6.5
DEFAULT BRANCH: develop
Ran
Jobs 3
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
947

push

travis-ci

isislovecruft 
Remove the idea of "categories". Proxies constitute another cluster.

This completely removes the half-baked idea of "IP categories" from
BridgeDB's codebase.  An IPBasedDistributor now holds a bunch of proxies
(in one single bridgedb.proxy.ProxySet).  These proxies have their own
"cluster".  End of story.  No more messing around with both "categories"
and "clusters", because nobody ever knew what either of those were
anyway, much less why they were different.

 * CHANGE IPBasedDistributor.categories to be a single
   bridgedb.proxy.ProxySet, rather than a list of lists.  ProxySets have
   "tags" for each proxy within them, and can efficiently separate
   proxies based upon tag(s), so there is no longer any need to have a
   list of lists to keep the proxies separate.  Besides, in the end, we
   treat all clients coming from any proxy the same, regardless of
   whether the proxy is a Tor Exit relay or some other known open proxy.

 * RENAME IPBasedDistributor.categories → IPBasedDistributor.proxies,
   because no one ever understood what an "IP category" was.

 * CHANGE IPBasedDistributor.numberOfClusters to always include the
   "cluster" for clients coming from proxies, if
   IPBasedDistributor.proxies is configured.

 * ADD IPBasedDistributor.proxyCluster, which is an integer pointing to
   the cluster number for the proxies cluster.  If there is no cluster
   for proxies, it is set to 0.  Otherwise, it points to the last
   cluster.

 * CHANGE the numbering of clusters in IPBasedDistributor to start from
   1 instead of 0.  While this might make iteration over all of the
   clusters increasingly subject to fencepost errors, it still makes the
   code feel more intuitive, i.e. "The first cluster is 1 out of 5 total
   clusters, and the last cluster is 5/5" rather than "The first cluster
   is number 0 out of 5 total clusters, and the last 4/5".

 * CHANGE a couple test cases which expected
   IPBasedDistributor.categories to exist.

 * UPDATE docum... (continued)

3527 of 4406 relevant lines covered (80.05%)

2.4 hits per line

Jobs
ID Job ID Ran Files Coverage
1 947.1 (TWISTED_VERSION=13.2.0 PYOPENSSL_VERSION=0.13.1) 38
79.8
 Travis Job 947.1
2 947.2 (TWISTED_VERSION=14.0.2 PYOPENSSL_VERSION=0.14) 38
79.96
 Travis Job 947.2
3 947.3 (TWISTED_VERSION=15.0.0 PYOPENSSL_VERSION=0.14) 38
79.96
 Travis Job 947.3
Source Files on build 947
Coverage ∆ File Lines Relevant Covered Missed Hits/Line