• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

trufflesuite / ganache-core / 2093
83%

Build:
DEFAULT BRANCH: develop
Ran 30 Apr 2019 09:15PM UTC
Jobs 2
Files 34
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2093

push

travis-ci

web-flow
Fix forked `debug_traceTransaction` (#420)

This fixes the following issues:

* Web3 treats block numbers stored as hex as block hashes.

* When tracing a transaction we need to make sure the forked trie is block-number aware.

* Ensure addresses and keys are encoded properly before sending to the main node, or we may get an error back if the hex representation needs to be padded with a 0..

* When tracing a transaction the VM may ask for block by passing in a Buffer of the number instead of a hex string. Handle both.

* Don't even let the vm try to flush the a traced transaction's block's internal _cache to the stateTrie. When forking, some of the data that the traced function may request will exist only on the main chain. Because we pretty much lie to the VM by telling it we DO have data in our Trie, when we really don't, it gets lost during the commit phase when it traverses the "borrowed" data's trie (as it may not have a valid root). Because this is a trace, and we don't need to commit the data, duck punching the flush method (the simplest method I could find) is fine. Remove this and you may see the infamous Uncaught TypeError: Cannot read property 'pop' of undefined error!

892 of 1236 branches covered (72.17%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

2492 of 2905 relevant lines covered (85.78%)

1904.07 hits per line

Jobs
ID Job ID Ran Files Coverage
2 2093.2 30 Apr 2019 09:15PM UTC 0
81.72
Travis Job 2093.2
3 2093.3 30 Apr 2019 09:18PM UTC 0
81.72
Travis Job 2093.3
Source Files on build 2093
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2093
  • 8ad1ab29 on github
  • Prev Build on develop (#2076)
  • Next Build on develop (#2095)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc