435
72%

Ran 30 Apr 2019 03:05PM UTC

Jobs 1

Files 529

Run time 33s

Badge

Embed ▾

pending completion

Build # 435

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

ISSUE #2067: reduce byte[] allocation in add entry

Descriptions of the changes in this PR:
This change removes a byte[] copy in DigestManager digest calculation
(computeDigestAndPackageForSending)
that puts crc header and payload in a continuous buffer. Instead,
it uses protobuf ByteString.concat to concatenate header and payload
without copy when building protobuf message.




### Motivation

In add entry code path, I see lots of byte[] allocated to do digest calculation.  It's possible to not allocate byte[]. 

### Changes

Don't allocate a ByteBuf to copy data. Keep header and data separate, but use ByteString.concat when construct protobuf message.

Master Issue: #2067 




Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #2068 from mtang01/add_entry_mem, closes #2067

Run Details

26707 of 37546 relevant lines covered (71.13%)

0.71 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	435.1	30 Apr 2019 03:05PM UTC	0	71.13

Source Files on build 435

Detailed source file information is not available for this build.

apache / bookkeeper / 435
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 435

apache / bookkeeper / 435 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 435

apache / bookkeeper / 435
72%

README BADGES
x