zalando-incubator / stackset-controller / 696
50%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 7
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
696

push

travis-ci

mikkeloscar 
Only applying StackLifeCycle.Limit to stacks without traffic and enforcing it to >= 1 (#125)

* Changing the semantics of StackLifeCycle.Limit and enforcing it to >= 1

Changing the semantics of StackLifeCycle.Limit to exclude the stack
that's getting traffic. So `StackLifeCycle.Limit: 1` would now mean, keep
at least 2 stacks. This is more intuitive because the stack that's getting
traffic would never be deleted anyways.

Also modifying the CRD definition to enforce StackLifeCycle.Limit >= 1.
This is so people have at least 1 stack around to safely switch to. Since
HPAs are now not deleted, this extra stack should get safely downscaled
without costing too much.

Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>

* Only applying historyLimit to stacks without traffic

Excluding stacks with traffic from history limit, because that's more
intuitive. Also adding a relevant unit test

Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>

* Only counting gcCandidates as StackLifeCycle.Limit

To simplify the code counting gcCandidates as StackLifeCycle.Limit
instead of calculating stacks without traffic separately

Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>

* Fixing broken e2e test TestStackTTLForLatestStack

Since the latest stack won't get deleted with "StackLifeCycle.Limit: 1"
anymore, testing that the latest stack will get scaled down instead.

Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>

* Fixing broken e2e test TestStackTTLWithIngress

Change the no. of expected stacks since "StackLifeCycle.Limit: 3" will
now keep 4 stacks. 1 with traffic and 3 extras.

Signed-off-by: Muhammad Muaaz Saleem <muhammad.muaaz.saleem@zalando.de>

770 of 1681 relevant lines covered (45.81%)

1.86 hits per line

Jobs
ID Job ID Ran Files Coverage
1 696.1 (GO111MODULE=on GOLANGCI_RELEASE="v1.16.0") 0
45.81
 Travis Job 696.1
Source Files on build 696
Detailed source file information is not available for this build.