10537
66%

Ran 30 Apr 2019 04:48AM UTC

Jobs 1

Files 93

Run time 5s

Badge

Embed ▾

Committed 29 Apr 2019 04:57PM UTC coverage: 60.969%. Remained the same

Build # 10537

Build Type

cron

travis-ci

Committed by

jsha

Commit Message

sa: return corepb.Empty{} not nil. (#4183)

The new `RevokeAuthorizationsByDomain2` and `DeactivateAuthorization2`
SA RPCs are declared to return `*corepb.Empty, error` but were
implemented to `return nil, nil` for the success case. This causes
a gRPC unmarshal error:

```
E151233 boulder-sa [AUDIT] grpc: server failed to encode response:  rpc
error: code = Internal desc = grpc: error while marshaling: proto:
Marshal called with nil
```

Both RPCs should `return &corepb.Empty{}, nil` to avoid this.

Run Details

11089 of 18188 relevant lines covered (60.97%)

0.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
6	10537.6 (RUN="coverage" CONTAINER="netaccess")	30 Apr 2019 04:48AM UTC	0	60.97	Travis Job 10537.6

Source Files on build 10537

Detailed source file information is not available for this build.

letsencrypt / boulder / 10537
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10537

letsencrypt / boulder / 10537 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10537

letsencrypt / boulder / 10537
66%

README BADGES
x