tarantool / tarantool / 16787

83%

master: 88%

push

travis-ci

<a href="https://github.com/tarantool/tarantool/commit/<a class=hub.com/tarantool/tarantool/commit/f14619d989c057f3945df63b674abbe3dbcade7d">f14619d98<a href="https://github.com/tarantool/tarantool/commit/f14619d989c057f3945df63b674abbe3dbcade7d">&quot;&gt;vinyl: be pessimistic about write rate when setting dump watermark

We set the dump watermark using the following formula

    limit - watermark     watermark
    ---------------- = --------------
       write_rate      dump_bandwidth

This ensures that by the time we run out of memory quota, memory
dump will have been completed and we&amp;#39;ll be able to proceed. Here
the write_rate is the expected rate at which the workload will
write to the database while the dump is in progress. Once the dump
is started, we throttle the workload in case it exceeds this rate.

Currently, we estimate the write rate as a moving average observed
for the last 5 seconds. This performs poorly unless the workload
write rate is perfectly stable: if the 5 second average turns out to
be even slightly less than the max rate, the workload may experience
long stalls during memory dump.

To avoid that let&amp;#39;s use the max write rate multiplied by 1.5 instead
of the average when setting the watermark. This means that we will
start dump earlier than we probably could, but at the same time this
will tolerate write rate fluctuations thus minimizing the probability
of stalls.

Closes #4166

(cherry picked from commit </a><a class="double-link" href="https://github.com/tarantool/tarantool/commit/<a class="double-link" href="https://github.com/tarantool/tarantool/commit/b9b8e8af4103a43d3f64c1bf6622f80a7902ccb8">b9b8e8af4</a>">b9b8e8af4</a><a href="https://github.com/tarantool/tarantool/commit/f14619d989c057f3945df63b674abbe3dbcade7d">)

6 of 6 new or added lines in 1 file covered. (100.0%)

41539 of 50382 relevant lines covered (82.45%)

858152.68 hits per line