1658
83%

Ran 29 Apr 2019 07:36PM UTC

Jobs 10

Files 17

Run time 6min

Badge

Embed ▾

Committed 23 Apr 2019 11:20AM UTC coverage: 80.673%. Remained the same

Build # 1658

Build Type

cron

travis-ci

Committed by

julienschmidt

Commit Message

connection: interpolate uint64 parameters (#955)

PR #838 introduced a fix for the driver's custom Value Converter that
stopped emitting large uint64 `driver.Value`s as a string. Instead, now
_all_ uint{8,16,32,64} values passed to the driver are returned as
uint64, and `packets.c` now explicitly handles `driver.Value` instances
that are uint64.

However, the update in `packets.c` only applies when sending
`driver.Value` arguments to the server. When a connection is set up
using `InterpolateParams = true` and query interpolation happens inside
of the driver, the `(*mysqlConn) interpolateParams` does **not** handle
uint64 values (which, again, are now passed by `database/sql` because
we've updated our value converter to generate them).

Because of this, any `DB.Query` operations which have an uint argument
(regardless of its size!!) will force the driver to return
`driver.ErrSkip`, disabling client interpolation for such queries.

We can fix this by updating `interpolateParams` like we previously
updated `writeExecutePacket`.

Run Details

2780 of 3446 relevant lines covered (80.67%)

571812.22 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1658.1	29 Apr 2019 07:36PM UTC	78.89	Travis Job 1658.1
2	1658.2	29 Apr 2019 07:36PM UTC	79.83	Travis Job 1658.2
3	1658.3	29 Apr 2019 07:36PM UTC	79.83	Travis Job 1658.3
4	1658.4	29 Apr 2019 07:36PM UTC	79.83	Travis Job 1658.4
5	1658.5	29 Apr 2019 07:39PM UTC	79.83	Travis Job 1658.5
6	1658.6 (DB=MYSQL8)	29 Apr 2019 07:39PM UTC	80.21	Travis Job 1658.6
7	1658.7 (DB=MYSQL57)	29 Apr 2019 07:38PM UTC	80.15	Travis Job 1658.7
8	1658.8 (DB=MARIA55)	29 Apr 2019 07:39PM UTC	79.51	Travis Job 1658.8
9	1658.9 (DB=MARIA10_1)	29 Apr 2019 07:39PM UTC	79.98	Travis Job 1658.9
10	1658.10	29 Apr 2019 07:42PM UTC	80.18	Travis Job 1658.10

Source Files on build 1658

Detailed source file information is not available for this build.

go-sql-driver / mysql / 1658
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1658

go-sql-driver / mysql / 1658 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1658

go-sql-driver / mysql / 1658
83%

README BADGES
x