Tencent / rapidjson / 2150

100%

master: 100%

Pull #1503

travis-ci

Safer GenericValue& operator=(GenericValue& rhs).

When rhs is a sub-Value of *this, destroying *this also destroys/frees
rhs, thus the following RawAssign(rhs) crashes.

Address this by saving/moving rhs to a temporary first, which clears rhs
and avoids its destruction with *this.

The crash can be reproduced in test Value.MergeDuplicateKey by using the
CrtAllocator instead of the default Document's MemoryPoolAllocator.

4 of 4 new or added lines in 1 file covered. (100.0%)

5156 of 5160 relevant lines covered (99.92%)

1710642.02 hits per line