cloudmarker / cloudmarker / 630

84%

push

travis-ci-com

Copy ext from NSG/firewall to firewall rules

The `_get_normalized_firewall_rules()` function in `AzureCloud` and
`GCPCloud` have been updated to copy the `ext` properties from the
NSG/firewall records generated by the plugins into the firewall rule
records generated from the NSG/firewall records.

To achieve this, the `_get_normalized_firewall_rules()` functions have
been modified. They used to accept raw NSG/firewall record as the input
parameter. Now they accept NSG/firewall record generated by the
plugins instead. This was necessary because the records generated by
the plugins contain the top-level keys `raw`, `ext`, and `com`, of
which we want to pick the `ext` bucket and copy it to the new firewall
rule records generated.

323 of 340 branches covered (95.0%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

1569 of 1662 relevant lines covered (94.4%)

2.83 hits per line