5093
94%
master: 94%

Ran 21 Apr 2019 09:00AM UTC

Jobs 1

Files 79

Run time 4s

Badge

Embed ▾

pending completion

Build # 5093

Build Type

Pull #1007

travis-ci

Committed by

web-flow

Commit Message

IndexTest: Simplify assertions

In IndexTest, we create our own method IndexTest#assertCreateFailure
to encapsulate the idea of asserting thrown exceptions. Tests call
the respective assertCreateZeroBasedFailure or
assertCreateOneBasedFailure that acts as a wrapper to
assertCreateFailure.

As per a previous commit, tests should directly directly use
Assert#assertThrows to test for the correct exception.

Let's migrate all tests to use Assert#assertThrows instead.

As a result, we no longer need IndexTest#assertCreateFailure. Tests
can also directly call Assert#assertThrows, so abstraction using
assertCreateZeroBasedFailure and assertCreateOneBasedFailure methods
provide little benefit.

Let's:
* remove the IndexTest#assertCreateFailure method
* remove the IndexTest#assertCreateZero/OneBasedFailure methods

This will simplify our code base and adhere closer to the DRY
principle instead of re-implementing methods.

Pull Request Pull Request #1007: Simplify tests for exception handling behavior

Run Details

1395 of 1488 relevant lines covered (93.75%)

0.94 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5093.1	21 Apr 2019 09:00AM UTC	0	93.75	Travis Job 5093.1

Source Files on build 5093

Detailed source file information is not available for this build.

se-edu / addressbook-level4 / 5093
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5093

se-edu / addressbook-level4 / 5093 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5093

se-edu / addressbook-level4 / 5093
94%
master: 94%

README BADGES
x