helpscout / hsds-react / 2017

94%

push

travis-ci

ScrollLock: Locking fix + resolve console warning (#587)

* ScrollLock: Locking fix + resolve console warning

This update fixes the ScrollLock mechanism to work with the newer browser +
React handling for `wheel` events.

The event listener is now added directly to the DOM node via `addEventListener`,
rather than tapping into the `onWheel` callback from React, which is now
considered "passive", and no longer provides us with the correct `eventTarget`.

`@helpscout/cyan` was added to help make it (much MUCH) easier to write
`wheel` event based tests, since these are now fired outside of React.

* Rename ScrollLock.test file

* Remove rAF stubbing. Relying on Cyan to do it.

* Update cyan to the latest v0.0.15

3702 of 3702 branches covered (100.0%)

Branch coverage included in aggregate %.

7625 of 7625 relevant lines covered (100.0%)

277.53 hits per line