Coveralls logob

zendframework / zf2 / 13430
85%

DEFAULT BRANCH: master
Repo Added 03 May 2013 12:59AM UTC
Total Files 2171
# Builds 2178 Last
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7 Apr 2015 - 13:37 coverage remained the same at 81.213%
13430

Pull #7429

travis-ci

D4c439f027e5e2e32cc272c33af5518b?size=18&default=identicontaiar 
Not treated condition on rendering console action

I was getting the following when using PhpRender() in some console actions:

```console
Fatal error: Call to a member function hasChildren() on boolean in C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\Mvc\View\Console\DefaultRenderingStrategy.php on line 55

Call Stack:
    0.0000     124912   1. {main}() C:\Users\taiar\Documents\NetBeansProjects\phila\public\index.php:0
    0.3810    7488888   2. Zend\Mvc\Application->run() C:\Users\taiar\Documents\NetBeansProjects\phila\public\index.php:17
    1.2061   13544048   3. Zend\Mvc\Application->completeRequest() C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\Mvc\Application.php:327
    1.2061   13544096   4. Zend\EventManager\EventManager->trigger() C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\Mvc\Application.php:352
    1.2061   13544168   5. Zend\EventManager\EventManager->triggerListeners() C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\EventManager\EventManager.php:207
    1.2071   13545376   6. call_user_func:{C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\EventManager\EventManager.php:468}() C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\EventManager\EventManager.php:468
    1.2071   13545560   7. Zend\Mvc\View\Console\DefaultRenderingStrategy->render() C:\Users\taiar\Documents\NetBeansProjects\phila\vendor\zendframework\zendframework\library\Zend\EventManager\EventManager.php:468
```

Then I found, by debugging that ```if (empty($result))``` doesn't catch the condition when ```$result``` was simply a ```true``` valeu (wich was happening in my case.

The proposed patch just make it work.

Thanks.
Pull Request #7429: Untreated condition on rendering console action

63870 of 78645 relevant lines covered (81.21%)

37.5 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
91.67
 0.0% library/Zend/Db/Sql/Select.php
1
100.0
 0.0% library/Zend/Filter/FilterPluginManager.php
1
91.89
 0.0% library/Zend/Session/AbstractContainer.php
1
49.22
 0.0% library/Zend/Session/Storage/AbstractSessionArrayStorage.php
1
87.88
 0.0% library/Zend/View/Helper/Escaper/AbstractHelper.php
2
83.33
 0.0% library/Zend/Db/Adapter/Driver/Pdo/Result.php
2
82.89
 0.0% library/Zend/Filter/FilterChain.php
4
91.92
 0.0% library/Zend/View/Model/ViewModel.php
5
94.81
 0.0% library/Zend/Db/Sql/Insert.php
6
85.71
 0.0% library/Zend/Filter/Word/AbstractSeparator.php
7
91.3
 0.0% library/Zend/Db/Sql/Expression.php
Jobs
Coverage Job Files Covered Ran
81.21
 13430.4 2171 07 Apr 2015 01:48PM UTC Travis Job 13430.4
Source Files on build 13430
Coverage ∆ File Lines Relevant Covered Missed Hits/Line