EFForg / https-everywhere / 47980

54%

push

travis-ci

Fix Chromium local store exception (#17557)

At least on Chromium 73 when opening the extension options window an
exception
"TypeError: Illegal invocation: Function must be called on an object of type StorageArea"
is thrown, which results in empty update channels page.

It looks like chrome.storage.local methods need to be called while bound to
the chrome.storage.local object.

According to
https://github.com/KeithHenry/chromeExtensionAsync/issues/10
https://github.com/wtetsu/mouse-dictionary/issues/16 this Chromium change
has been introduced probably around version 70 or 72.

Automatic ruleset updates might have been affected by this, too.

316 of 951 branches covered (33.23%)

Branch coverage included in aggregate %.

921 of 1917 relevant lines covered (48.04%)

9.1 hits per line