tarantool / tarantool / 16494

83%

master: 88%

push

travis-ci

replication: allow to change instance id during join

Before rebootstrapping a replica, the admin may delete it from the
_cluster space on the master. If he doesn't make a checkpoint after
that, rebootstrap will fail with

  E> ER_LOCAL_INSTANCE_ID_IS_READ_ONLY: The local instance id 2 is read-only

This is sort of unexpected. Let's fix this issue by allowing replicas to
change their id during join.

A note about replication/misc test. The test used this error to check
that a master instance doesn't crash in case a replica fails to
bootstrap. However, we can simply set mismatching replicaset UUIDs to
get the same effect.

Closes #4107

(cherry picked from commit 319ab0ae5)

9 of 9 new or added lines in 1 file covered. (100.0%)

41423 of 50320 relevant lines covered (82.32%)

834612.41 hits per line