16491
87%

Ran 11 Apr 2019 01:24PM UTC

Jobs 1

Files 373

Run time 50s

Badge

Embed ▾

pending completion

Build # 16491

Build Type

push

travis-ci

Committed by

locker

Commit Message

replication: fix garbage collection logic

Currently, the garbage collector works with vclock signatures and
doesn't take into account vclock components. This works as long as
the caller (i.e. relay) makes sure that it doesn't advance a consumer
associated with a replica unless its acknowledged vclock is greater
than or equal to the vclock of a WAL file fed to it. The bug is that
it does not - it only compares vclock signatures. As a result, if
a replica has some local changes or changes pulled from other members
of the cluster, which render its signature greater, the master may
remove files that are still needed by the replica, permanently breaking
replication and requiring rebootstrap.

I guess the proper fix would be teaching the garbage collector
operate on vclock components rather than signatures, but it's rather
difficult to implement. This patch is a quick fix, which simply
replaces vclock signature comparison in relay with vclock_compare.

Closes #4106

Run Details

65323 of 80096 relevant lines covered (81.56%)

2316109.67 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	16491.4 (TARGET=coverage)	11 Apr 2019 01:24PM UTC	373	81.56	Travis Job 16491.4

tarantool / tarantool / 16491
87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16491

tarantool / tarantool / 16491 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16491

tarantool / tarantool / 16491
87%

README BADGES
x