2838
86%

Ran 08 Apr 2019 06:15PM UTC

Jobs 1

Files 890

Run time 1min

Badge

Embed ▾

pending completion

Build # 2838

Build Type

push

travis-ci

Committed by

mpkorstanje

Commit Message

[Core] Simplify duplicate feature detection

Between #165 and #259 cucumber would start to ignore duplicate features
by taking their MD5 sum and comparing newly parsed features. Replacing
the set of MD5 sums with a map of source to features simplifies the code
and allows duplicates to be logged as warnings.

I couldn't discover any good reason to use an MD5 hash over javas
`hashCode` and `equals`.

 1) Memory consumption doesn't to be a problem. `CucumberFeature`
 already keeps a reference the original source.

 2) Collision doesn't appear to be a problem. `hashCode` produces a 32
 bit hash. So by the birth-day paradox math we'd need approximately 9000
 feature files for a 1% chance of collision.

Run Details

4466 of 5186 relevant lines covered (86.12%)

378.5 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	2838.2	08 Apr 2019 06:15PM UTC	0	86.12	Travis Job 2838.2

Source Files on build 2838

Detailed source file information is not available for this build.

cucumber / cucumber-jvm / 2838
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2838

cucumber / cucumber-jvm / 2838 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2838

cucumber / cucumber-jvm / 2838
86%

README BADGES
x