wooga / atlas-hockey / 21
79%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 3
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
21

push

jenkins

Improve publish logic (#3)

## Description

This patch improves the `HockeyUploadTask` in two ways.

* switch to `apache:httpclient` for upload
* save upload result metadata `HockeyAppVersion`

I moved from using curl to `httpclient`. The setup is very simple if a little bit verbose. But it supports everything we need to `POST` a multipart payload. The main reason why I wanted to switch is to read the response body of the request. Hockey returns a JSON body with information about the created app version

**example from [support.hockeyapp.net][api-versions]
```json
{
    "title": "HockeyTest",
    "appsize": 1598428,
    "timestamp": 1308930206,
    "device_family": "iPhone/iPod",
    "minimum_os_version": "4.0",
    "notes": "<p>Some new features and fixed bugs.</p>",
    "version": "8",
    "shortversion": "1.0",
    "status": 2,
    "config_url": "https://rink.hockeyapp.net/manage/apps/123/app_versions/8",
    "public_url": "https://rink.hockeyapp.net/apps/1234567890abcdef1234567890abcdef"
}
```

> The actual body contains more fields.

The `HockeyUploadTask` will save this result as an `Outputfile` and also parse it into a simple model `HockeyAppVersion`. This allows other tasks to access this information.

## Changes

![ADD] new compile dependency `org.apache.httpcomponents:httpclient`
![ADD] new compile dependency `org.apache.httpcomponents:httpmime`
![IMPROVE] switch upload logic from `curl` to `httpclient`
![IMPROVE] save upload result body in file
![IMPROVE] provide runtime model for upload result

[api-versions]:    https://support.hockeyapp.net/kb/api/api-versions#upload-version

[NEW]:https://atlas-resources.wooga.com/icons/icon_new.svg "New"
[ADD]:http://resources.atlas.wooga.com/icons/icon_add.svg "Add"
[IMPROVE]:http://resources.atlas.wooga.com/icons/icon_improve.svg "IMPROVE"
[CHANGE]:http://resources.atlas.wooga.com/icons/icon_change.svg "Change"
[FIX]:http://resources.atlas.wooga.com/icons/i... (continued)

50 of 61 relevant lines covered (81.97%)

1.66 hits per line

Jobs
ID Job ID Ran Files Coverage
1 21.1 0
81.97
2 21.2 0
83.61
Source Files on build 21
Detailed source file information is not available for this build.