mobxjs / mobx-react-lite / 417

95%

push

travis-ci

Make StrictMode happy (#119)

* Add test for proper reaction disposal in StrictMode

* Use jest-mock-console instead of mocking console.error by hand

* Move test into separate useObserver test file

I've tweaked the test name to reflect what it's really checking for.

* Add a second test to verify that reactions are disposed after unmount

N.B. Depending on the implementation of a fix, this test might need some
extra delays or act() calls to trigger a delayed cleanup before asserting that
all is clean.

* Remove 'leak' test as it's a separately-solvable issue.

(I'll move this test into another PR.)

* Track whether the current component has been committed before forcing update

* Remove the now-unused useUnmount

22 of 22 branches covered (100.0%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

120 of 121 relevant lines covered (99.17%)

28.68 hits per line