• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

amiv-eth / amivapi / 629
94%

Build:
DEFAULT BRANCH: master
Ran 30 Mar 2019 02:39PM UTC
Jobs 2
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
629

push

travis-ci

web-flow
Fix home link methods (#363)

For the home endpoint, some link methods were incorrect, i.e. the API would report that some methods are allowed for the current user (although they were not) and some of the reported methods would not be allowed.

This was the result of to unrelated problems:

1. Not allowed `HEAD`: Eve automatically allows `HEAD` requests if `GET` is possible. However, if `GET` is set to `public_methods`, `HEAD` *is not* automatically included, and has to be set explicitly. Unaware of this, the API would report that `HEAD` is allowed, while it was not. I have corrected the respective resource configs such that `HEAD` is allowed whenever `GET` is, as it is intended.

2. Allowed `GET` if it is not: Some resources using `AdminOnlyAuth` would not create a user lookup filter, but instead `abort`. The API had no way to check this properly, and would report that `GET` is possible (even if it would be aborted. I have changed the output of creating a lookup filter such that not allowing *any* lookup for a user can be properly returned. Now the API can correctly determine whether `GET` is possible or not.

Aside from that, I improved the tests for links on `/` to actually test all reported methods.

Closes #343.
Jobs
ID Job ID Ran Files Coverage
1 629.1 (TOXENV=py35) 30 Mar 2019 02:40PM UTC 0
94.26
Travis Job 629.1
3 629.3 (TOXENV=flake8) 30 Mar 2019 02:39PM UTC 0
Travis Job 629.3
Source Files on build 629
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #629
  • 5864cb8a on github
  • Prev Build on master (#627)
  • Next Build on master (#635)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc