nats-io / node-nats-streaming / 249

94%

push

travis-ci

- internal request/reply timeouts of the stan protocol now have their timeouts specified by the `connectTimeout` property as done in the go-nats-streaming client. (#102)

### connectTimeout changes
- internal request/reply timeouts of the stan protocol now have their timeouts specified by the `connectTimeout` property as done in the go-nats-streaming client.

### ES6 Changes
- changed `var` to `const`/`let`. Use of arrow functions everywhere it could simplify code.

### Tests
- move to nyc from istanbul exposed a number of tests hanging because timers were not properly closed under some conditions (this required changes in node-nats), as well as insuring that all tests call `close()` on the connection.

### Updated Samples/Bench tools
- the samples and tools hadn't been updated or reviewed since initially written. They received some love.

### Dependency updates
- updated all dev depedencies
- replaced istanbul with nyc

155 of 195 branches covered (79.49%)

445 of 445 new or added lines in 1 file covered. (100.0%)

464 of 495 relevant lines covered (93.74%)

26.71 hits per line