• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pions / ice / 17
80%
master: %

Build:
Build:
LAST BUILD BRANCH: tcp-passive
DEFAULT BRANCH: master
Ran 27 Mar 2019 07:59AM UTC
Jobs 1
Files 10
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
17

Pull #3

travis-ci

web-flow
Optimize ice.Agent.getBestPair()

This function should be trivial but profiles show it taking 3-5% of my
application's CPU time. The problem is the constant creation of a
channel for message passing. This function is called by srtp.WriteRTP
for each packet, so it adds up.

My fix was to create a `runInner` function that utilizies a mutex. I
wanted to convert all `run` functions to `runInner` but the code
occasionally deadlocks in unit tests. The package is definitely a
candidate for a rewrite.

```
name           old time/op    new time/op    delta
GetBestPair-8     915ns ± 3%      80ns ± 4%  -91.23%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
GetBestPair-8      128B ± 0%       16B ± 0%  -87.50%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
GetBestPair-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.008 n=5+5)
```
Pull Request #3: Optimize ice.Agent.getBestPair()

40 of 40 new or added lines in 1 file covered. (100.0%)

932 of 1168 relevant lines covered (79.79%)

32.14 hits per line

Jobs
ID Job ID Ran Files Coverage
1 17.1 (GO111MODULE=on) 27 Mar 2019 07:59AM UTC 0
79.79
Travis Job 17.1
Source Files on build 17
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #17
  • Pull Request #3
  • PR Base - master (#12)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc