aiidateam / aiida_core / 5546

74%

push

travis-ci

Validate number of positional arguments passed to process function (#2619)

A process function that supported `**kwargs` could be called with more
positional arguments then the function signature declares, causing them
to be interpreted as keyword arguments, except that now the engine could
not determine their name, since it is neither in the signature, nor in
the function call and so no links would be created. This bug allowed
a process function to be called that would have missing input links.

To fix this we add an explicit check on call time that if a function is
dynamic, i.e. its signature allows `**kwargs` then the number of
positional arguments may not surpass the number of named parameters
defined in the signature.

7 of 7 new or added lines in 1 file covered. (100.0%)

21819 of 33469 relevant lines covered (65.19%)

2.56 hits per line