node-red / node-red / 4590

69%

push

travis-ci

Do not dynamically add/remove upgrade listener in ws nodes

The way we dynamically added/removed event handlers for the
upgrade event was causing problems with the way sockjs (as
used by the worldmap node) tries to intercept the event.

This fix means the ws nodes won't ever remove the upgrade
listener - it gets added once when the first ws node is
deployed and will then remain until the last ws node is
removed and the runtime restarted.

4417 of 6410 branches covered (68.91%)

9081 of 11881 relevant lines covered (76.43%)

148.98 hits per line