se-edu / addressbook-level4 / 5014

94%

push

travis-ci

<a href="https://github.com/se-edu/addressbook-level4/commit/<a class=hub.com/se-edu/addressbook-level4/commit/<a class="double-link" href="https://git"><a class=hub.com/se-edu/addressbook-level4/commit/<a class="double-link" href="https://git"><a class=hub.com/se-edu/addressbook-level4/commit/1cb12c6991a011a70ea48d0f2eae42beafbb810b">1cb12c699">&lt;a href=&quot;https://github.com/se-edu/addressbook-level4/commit/</a><a class="double-link" href="https://github.com/se-edu/addressbook-level4/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/se-edu/addressbook-level4/commit/1cb12c6991a011a70ea48d0f2eae42beafbb810b">1cb12c699</a><a href="https://github.com/se-edu/addressbook-level4/commit/1cb12c6991a011a70ea48d0f2eae42beafbb810b">&lt;a href=&quot;https://github.com/se-edu/addressbook-level4/commit/1cb12c6991a011a70ea48d0f2eae42beafbb810b&quot;&gt;&amp;quot;&amp;gt;StringUtilTest: Remove Hamcrest String matcher

Currently, in StringUtilTest#getDetails_exceptionGiven, we use
Hamcrest&amp;amp;#39;s string matching and assert libraries.
This library was introduced in [1], however no justification was
given on why we specifically used these Hamcrest libraries. In fact,
this is the only instance in the entire project where we use this
dependency.

We are only using the assertThat and contains API of the Hamcrest
library, whose corresponding functionality is already implemented in
JUnit#assertTrue and Java String#contains. The only extra benefit that
this Hamcrest library provides is in its more detailed error message
when tests fail [2]. While convenient, this functionality is not
absolutely critical. This is because developers can use the debugger
to inspect the state of messages right before the error.

There is more value in this case to standardise the usage of our
assert statements. The Hamcrest library introduces a new API that
developers of AB4 will have to learn. New developers might be confused
why we use two different APIs to conduct tests. By standardising to
use the JUnit assertTrue, we remove the need to learn multiple APIs,
while achieving the same outcome.

Hence, let&amp;amp;#39;s remove the Hamcrest libraries and replace them with their
equival... (continued)

1395 of 1488 relevant lines covered (93.75%)

0.94 hits per line