1462
100%

Ran 19 Mar 2019 07:00AM UTC

Jobs 4

Files 30

Run time 13min

Badge

Embed ▾

pending completion

Build # 1462

Build Type

push

travis-ci

Committed by

jakirkham

Commit Message

#272 Fix race condition in DirectoryStore (#318)

* #272 fix race condition to make folders in directory store

* #272 remove FileNotFoundError for python 2 support

* Change OSError to KeyError to make tests pass

* Only catch `OSError` if its `errno` equal `EEXIST`

On Python 3, we would only want to catch the race case here by checking
for the `FileExistsError` and suppressing raising for that case. However
there is no `FileExistsError` on Python 2. Only `OSError` exists on
Python 2/3. However that catches some other errors that we might not
want to suppress here. So we check the `errno` of the `OSError` instance
to verify it is caused by an existing file/directory represented by the
`EEXIST` error number. This amounts to catching the `FileExistsError` in
a Python 2/3 friendly way. All other `OSErrors` we raise as before.

* Drop generic `Exception` case in `DirectoryStore`

As we now properly handle the existing file case properly, go ahead and
drop the generic exception case. This should now raise some errors that
were hidden previously.

Run Details

9468 of 9468 relevant lines covered (100.0%)

3.96 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1462.1	19 Mar 2019 07:00AM UTC	98.94	Travis Job 1462.1
2	1462.2	19 Mar 2019 07:04AM UTC	98.92	Travis Job 1462.2
3	1462.3	19 Mar 2019 07:13AM UTC	98.92	Travis Job 1462.3
4	1462.4	19 Mar 2019 07:06AM UTC	99.43	Travis Job 1462.4

Source Files on build 1462

Detailed source file information is not available for this build.

zarr-developers / zarr / 1462
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1462

zarr-developers / zarr / 1462 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1462

zarr-developers / zarr / 1462
100%

README BADGES
x