dpgaspar / Flask-AppBuilder / 1875

74%

Pull #926

travis-ci

fix: 500 error when input username contains special characters

when input username contains special characters, i.e "root🈳",
server will display 500 error page, and expose scripts filepath:

```
Stacktrace
         Traceback (most recent call last):
  File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/views.py", line 381, in login
    user = self.appbuilder.sm.auth_user_db(form.username.data, form.password.data)
  File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/manager.py", line 529, in auth_user_db
    log.info(LOGMSG_WAR_SEC_LOGIN_FAILED.format(username))
UnicodeEncodeError: 'ascii' codec can't encode character u'\U0001f233' in position 4: ordinal not in range(128)

```

After username.encode('utf-8'), 500 error page disappears.

2 of 2 new or added lines in 1 file covered. (100.0%)

4922 of 7009 relevant lines covered (70.22%)

1.4 hits per line