509
38%
master: 39%

Ran 14 Mar 2019 11:45AM UTC

Jobs 1

Files 8

Run time 1s

Badge

Embed ▾

pending completion

Build # 509

Build Type

push

travis-ci

Committed by

nevun

Commit Message

Tighten the salt_len check to avoid a potential stack buf overwrite further down.

If salt_len was 256:

 for (block_count = 1; block_count <= l; block_count++) {
                unsigned char block[256]; /* A big chunk, that's 2048 bits */
[ ... ]

                memcpy(block, salt, salt_len);
                block[salt_len + 0] = (block_count & 0xff000000) >> 24;
                block[salt_len + 1] = (block_count & 0x00ff0000) >> 16;
                block[salt_len + 2] = (block_count & 0x0000ff00) >>  8;
                block[salt_len + 3] = (block_count & 0x000000ff) >>  0;

        block[256] is outside the buffer and then the next lines would overwrite 3 more bytes

Run Details

580 of 1518 relevant lines covered (38.21%)

396.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
11	509.11 (LIBUSB=libusb-1.0 EXTRA="libusb-1.0-0-dev libjson0-dev lcov" COVERAGE="--enable-coverage")	14 Mar 2019 11:45AM UTC	0	38.21	Travis Job 509.11

Yubico / yubikey-personalization / 509
38%
master: 39%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 509

Yubico / yubikey-personalization / 509 38% master: 39%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 509

Yubico / yubikey-personalization / 509
38%
master: 39%

README BADGES
x