1849
37%
master: 40%

Ran 13 Mar 2019 11:05AM UTC

Jobs 1

Files 830

Run time 57s

Badge

Embed ▾

pending completion

Build # 1849

Build Type

push

travis-ci

Committed by

Flowdalic

Commit Message

StanzaDroppedListener for XEP-0198 resumption failures

If a stream resume fails, smack will re-send all queued stanzas after a
reconnect. However, it does not make sense to re-send them:

* IQs / IQ responses have probably timed out
* MUC messages and PMs will be rejected as you haven't rejoined yet
* regular messages should be amended with a <delay> element

This patch adds a StanzaDroppedListener interface to the
XMPPTCPConnection. If at least one StanzaDroppedListener is provided,
all queued messages will be drained into the StanzaDroppedListener(s).
Otherwise, the original behavior of attempting to transmit them will be
followed.

Discussion: https://discourse.igniterealtime.org/t/xep-0198-resume-failure-reconnect-resending-of-muc-messages/83510/3

Signed-off-by: Georg Lukas <georg@op-co.de>

Run Details

11668 of 31657 relevant lines covered (36.86%)

0.37 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1849.1	13 Mar 2019 11:05AM UTC	830	36.86	Travis Job 1849.1

igniterealtime / Smack / 1849
37%
master: 40%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1849

igniterealtime / Smack / 1849 37% master: 40%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1849

igniterealtime / Smack / 1849
37%
master: 40%

README BADGES
x