• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

apache / struts / 1445
51%

Build:
DEFAULT BRANCH: master
Ran 11 Mar 2019 06:19AM UTC
Jobs 1
Files 1044
Run time 48s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1445

push

travis-ci

yasserzamani
Fix for default (un-configured) allowStaticFieldAccess state, Showcase Application in 2.6.x (#334)

* Fix for default un-configured allowStaticFieldAccess state:
1) Ensure OgnlValueStackFactory returns true for allowStaticFieldAccess when not configured (consistency - same as OgnlUtil does).
2) Add test to OgnlValueStackTest for the no allowStaticXXX flags present.

Minor config fixes for the Showcase Application in 2.6.x:
1) File upload examples.  Multiple file upload missing result page (list and array), added missing JSP.  Added missing input results in configuration.
2) File upload examples.  Fixed NPE for multiple file upload (array version) when no files selected.
3) Add manual test for public constant access via expression (to If tag JSP).

* Added missed logic elements from PR#320 (identified by Y. Zamani):
1) Added ognlAllowStaticFieldAccess field and getter/setter to ConstantConfig.
2) Added allowStaticFieldAccess (set to true) to default.properties.

* Follow-up commit:
- Fixed wrong package reference in testNullMethod(), as well as in new tets.
- Added additional tests to cover the full set of static access flag combinations.

* Follow-up commit:
- Fixed createValueStack() not setting allowStaticFieldAccess parameter.
- Removed 3 unused import statement.
- Refactored OgnlValueStackFactory creation logic into two utility methods: getValueStackFactory(), reloadValueStackFactory()
- Added one additional test with a raw OgnlValueStackFactory generated OgnlValueStack (staticMethodAccess false, staticFieldAccess true).
  Test confirms same result as with a default OgnlValueStackFactory.

7 of 7 new or added lines in 2 files covered. (100.0%)

27221 of 56252 relevant lines covered (48.39%)

0.48 hits per line

Jobs
ID Job ID Ran Files Coverage
3 1445.3 (STRUTS_IT=true) 11 Mar 2019 06:19AM UTC 0
48.39
Travis Job 1445.3
Source Files on build 1445
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1445
  • d3eb1fc5 on github
  • Prev Build on master (#1441)
  • Next Build on master (#1446)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc