spulec / moto / 4346
93%
master: 95%

LAST BUILD BRANCH: fix-request-id
DEFAULT BRANCH: master
Ran
Jobs 4
Files 303
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4346

Pull #2096

travis-ci

web-flow 
bugfix ebs volume tag behaviour

This commit modifies the response format of the ec2 calls
`create_volume` and `describe_volumes`. Previously, these calls would
always include a `Tags` key in the response, even when a volume has no tags.
Now, the `Tags` key will not be included in the response if the volume
has no tags.

When an EBS volume has no tags, calls to the aws ec2 endpoints `create_volume`
and `describe_volumes` do not include the `Tags` key in the
`response.Volumes[]` object.

However, moto does include the `Tags` key in this case. This discrepancy
in behaviour can result in code passing a moto test but failing in
production.

Sample snippets that trigger this condition:

```
def create_volume_and_then_get_tags_from_response():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    keys = volume_response['Keys']
```

```
def create_volume_and_then_get_tags_from_describe_volumes():
    client = boto3.client('ec2', region_name='us-east-1')
    volume_response = client.create_volume(
        Size=10,
        AvailabilityZone='us-east-1a'
    )
    volume_describe_response = client.describe_volumes()
    keys = volume_describe_response['Volumes'][0]['Keys']
```

Both sample snippets will succeed in a moto test, but fail with a
`KeyError` when using the aws api.
Pull Request #2096: Fix describe volumes response with no tags

27016 of 29130 relevant lines covered (92.74%)

3.4 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4346.1 (TEST_SERVER_MODE=false) 303
92.64
 Travis Job 4346.1
2 4346.2 (TEST_SERVER_MODE=false) 303
92.64
 Travis Job 4346.2
3 4346.3 (TEST_SERVER_MODE=false) 303
92.64
 Travis Job 4346.3
4 4346.4 (TEST_SERVER_MODE=true) 303
62.11
 Travis Job 4346.4
Source Files on build 4346